commit 6a5f26a9267f6daf77b904539a5a2c0c667087bd
author Mark Thomas <markt@apache.org> Thu Jul 03 23:18:07 2025 +0100
committer Mark Thomas <mark.thomas@broadcom.com> Mon Jul 21 16:14:21 2025 +0100
tree 73fd07299bf6cc2f5411d78a9ddb22e6d0216627
parent fb6aa0df142c54b06f119846d29289be1000c6ec

Re-factor - no functional change

Use better name and avoid possible concurrency issues

tck/src/main/java/com/sun/ts/tests/el/common/util/TestNum.java

diff --git a/tck/src/main/java/com/sun/ts/tests/el/common/util/TestNum.java b/tck/src/main/java/com/sun/ts/tests/el/common/util/TestNum.java
index 3abebd9..d543869 100644
--- a/tck/src/main/java/com/sun/ts/tests/el/common/util/TestNum.java
+++ b/tck/src/main/java/com/sun/ts/tests/el/common/util/TestNum.java
@@ -26,11 +26,7 @@
  */
 public final class TestNum {
 
-    private static final String COMPARATOR = "1";
-
-    private static ArrayList<Float> floatList;
-
-    private static ArrayList<Object> numberList;
+    private static final String NUMBER_REFERENCE = "1";
 
     /**
      * Private as this class will only have static methods and members.
@@ -45,7 +41,7 @@
      */
     public static ArrayList<Float> getFloatList() {
 
-        floatList = new ArrayList<>();
+        ArrayList<Float> floatList = new ArrayList<>();
 
         floatList.add(Float.valueOf("1.00005f"));
         floatList.add(Float.valueOf("1.5E-4d"));
@@ -64,19 +60,19 @@
      */
     public static ArrayList<Object> getNumberList() {
 
-        numberList = new ArrayList<>();
+        ArrayList<Object> numberList = new ArrayList<>();
 
-        numberList.add(BigDecimal.valueOf(Long.parseLong(COMPARATOR)));
-        numberList.add(Double.valueOf(COMPARATOR));
-        numberList.add(Float.valueOf(COMPARATOR));
-        numberList.add(COMPARATOR + ".0");
-        numberList.add(COMPARATOR + "e0");
-        numberList.add(COMPARATOR + "E0");
-        numberList.add(BigInteger.valueOf(Long.parseLong(COMPARATOR)));
-        numberList.add(Long.valueOf(COMPARATOR));
-        numberList.add(Integer.valueOf(COMPARATOR));
-        numberList.add(Short.valueOf(COMPARATOR));
-        numberList.add(Byte.valueOf(COMPARATOR));
+        numberList.add(BigDecimal.valueOf(Long.parseLong(NUMBER_REFERENCE)));
+        numberList.add(Double.valueOf(NUMBER_REFERENCE));
+        numberList.add(Float.valueOf(NUMBER_REFERENCE));
+        numberList.add(NUMBER_REFERENCE + ".0");
+        numberList.add(NUMBER_REFERENCE + "e0");
+        numberList.add(NUMBER_REFERENCE + "E0");
+        numberList.add(BigInteger.valueOf(Long.parseLong(NUMBER_REFERENCE)));
+        numberList.add(Long.valueOf(NUMBER_REFERENCE));
+        numberList.add(Integer.valueOf(NUMBER_REFERENCE));
+        numberList.add(Short.valueOf(NUMBER_REFERENCE));
+        numberList.add(Byte.valueOf(NUMBER_REFERENCE));
 
         return numberList;